It's had 41 commits, the majority of which are fiddling with the testing or the building, or, hilariously, the goddamn fucking requirements for the build and test environment.
The only single commit after the initial commit that touched the actual code that runs is removing the newline before the catch. That happens like two years in.
And all of this for catching and discarding an exception, which is a cardinal sin.
This seems really, really, really fucking stupid, but what do I know, I'm a filthy 1xer.
[deleted] ยท 43 points ยท Posted at 10:59:24 on October 12, 2018 ยท (Permalink)*
[deleted]
Hueho ยท 32 points ยท Posted at 13:19:46 on October 12, 2018 ยท (Permalink)
Oh hey remember when adding too many comments to your function would make it not able to be inlined?
Good times.
[deleted] ยท 25 points ยท Posted at 14:45:37 on October 12, 2018 ยท (Permalink)*
tuba_man ยท 10 points ยท Posted at 17:22:43 on October 12, 2018 ยท (Permalink)
unjerk - I don't deal with layer 7 of the OSI bean dip all that often so I gotta ask - I ignore errors in the logs all the time ("oh yeah, it just does that") but is there ever a valid reason to just discard errors in the code itself? I mean I guess "the thing I depend on throws an exception when I give it what should be a valid input" sort of stuff sometimes? I guess? no even that's fucky, what if your dependency gets its shit together
So it looks like the canonical suggested use for this is something like const wtf = niceTry(JSON.decode(problematic_string));
where problematic_string might end up causing the JSON decoder to throw. You don't care what's wrong with the JSON string, you just care about the result, and getting null back is perfectly fine because your code will handle it being null through some other means.
In this case, ignoring the exception and then handling the failure of the call isn't really fully evil, but it's certainly a problem. Exceptions should be exceptional circumstances that you build protections against.
A 10x developer is an individual who is thought to be as productive as 10 others in his or her field. The 10x developer would produce 10 times the outcomes of other colleagues, in a production, engineering or software design environment.
1xer means a regular developer, not those so-called code ninja, elite hacker whatever.
One day the javascript ecosystem will be so grand and all-encompassing every new project will be a series of module imports followed by a single app.run() call. no serious project will have fewer than 10,000 recursive dependencies. node devs will create a whole new filesystem to deal with the infinitely recursing chaos, after which six hundred js developers will reinvent that system in different but equally uninteresting ways.
eventually someone working at node will realise no actual code exists in the entire npm library and shut the whole thing down. web devs will shrug and go back to using jQuery for everything, like they secretly always wanted anyway.
I wonder if it is possible to create a dependency oriented programming language, where all functionality comes from pulling dependencies sequenced together with a single app.run() in the end
Peano numbers modeled as the length of a dependency chain
W E B S C A L E A R I T H M E T I C
R_Sholes ยท 22 points ยท Posted at 13:00:24 on October 12, 2018 ยท (Permalink)
There was some wonky start up with new paradigm of visual programming, where to build a hello world you'd pull from a global repository a block for string constant, a block for systemcall/write, a block for os/exit and a block for executable/linux-i386-elf and so on, and also it's all on a blockchain and every block you use would pay block's developer in some shitcoin, and I don't know whether they would charge for basic blocks or not.
Their whitepaper was going on and on about how hard it is to reuse code in traditional languages and how their "agents" are so much better, carefully avoiding mentioning how their "agents" are just functions, libraries, linkers and compilers but on a blockchain.
I wonder if it is possible to create a dependency oriented programming language
/uj Yesterday I was thinking that a programming language particularly suited to this should be created. Just for doing the NPM stuff but in a morally righteous way.
xtravar ยท 8 points ยท Posted at 13:24:22 on October 12, 2018 ยท (Permalink)
There are plenty of frameworks with that goal, where everything else is a dependency injection or data file. I donโt think itโs a terrible goal in and of itself...
Whatโs terrible is making a dependency for every function. If everything is an abstraction, nothing is.
eventually someone working at node will realise no actual code exists in the entire npm library and shut the whole thing down. web devs will shrug and go back to using jQuery for everything, like they secretly always wanted anyway.
Either that or our 100-billion-transistor CPUs with a terabyte of RAM will run software that's stuttery and slow while every webshit on the planet is like, "Why the fuck are you worried about RAM?"
In my experience, if you don't swallow exceptions they'll show up in logs and you're boss makes you fix them. This is why I use go. Go let's me ignore errors without writing any code which is very DRY.
How does shit like this even get added to projects? "Looks like I'm gonna need a try statement here. Hmmm, I wonder if someone has implemented this before me, I'd better search npm".
Why on earth isn't he using a library for this?!??!
leijurv ยท 52 points ยท Posted at 18:13:25 on October 12, 2018 ยท (Permalink)
Make a library for just that line and make a pull request, he'll have to accept it, to do otherwise would be compromising to his anti dependency inlining worldview.
rubyruy ยท 10 points ยท Posted at 23:44:56 on November 26, 2018 ยท (Permalink)
What did he expect? JavaScript developers are completely addicted to these 750,000 delicious, delicious libraries. You don't just quit using exception swallowing libraries cold turkey.
If you're so busy that you can't explain your decision to not inline a single function, why are you writing over 100 words to explain how busy you are?
It's called being a shameful and sad web dev who can't have their "intellect" challenged.
I simply do not have time to explain why your PR is bad. I can't just go around typing 100s and 100s of words explaining why I won't accept every single pull request. That would just take too much of my time, which I do not have. This PR goes against my design principles, explaining which would just take me way too long. You thin I have time to explain things in detail? I don't, I am a very busy developer. I'm sorry but I just won't discuss this, because of the time constraints, but I appreciate you making this pull request. If I had the time to explain why I won't accept the pull request (I don't), I definitely would. My design principles are simply too complex to summarize in a few sentences, it would take literal hours to lay out the foundations you would need to comprehend my design principals. I hope that helps you understand why a busy developer like me would simply not have the time to type out an explanation.
closed
[deleted] ยท 27 points ยท Posted at 19:51:45 on October 12, 2018 ยท (Permalink)
Still doesn't qualify as too heated, it's not like he was told to kys or there was a flame war about tabs vs spaces in the comments.
Dude just wanted another way to skirt around the technical side of the discussion.
YEPHENAS ยท 17 points ยท Posted at 13:13:23 on October 12, 2018 ยท (Permalink)
A little copying is better than a little dependency.
[deleted] ยท 24 points ยท Posted at 20:01:20 on October 12, 2018 ยท (Permalink)
- I don't agree with you because of my personal feelings and you are re being too pragmatic. Unsub, dislike, and lock the thread.
At what point we learn how to take the craftsmanship seriously and respect the career.
I hope we do not need to go with `leftPad` situation 10 times more and then politicians of this world tell us how to do our job because we suck at it.
No discipline, no respect what so ever.
This is disappointing and I hope I die before what makes me happy in life becomes what I hate the most because of computer science is driven by politics.
"Great power comes with great responsibilities"
But we have 0 accountability for our actions so we just forget about the responsibility part, for now.
Either we learn how to be disciplined or we will hate our job in the near future.
I donโt see how itโs that big a deal. He doesnโt want to encourage low-impact changes to how his package manages dependencies. So what?
syndbg ยท 27 points ยท Posted at 09:01:50 on October 12, 2018 ยท (Permalink)
uj
The funny jerk part is the nature of the PR, the attitude and github background of the maintainer and most importantly the problem itself.
it's 1 try-catch that anyone can write in any version of JS. Completely comical and misunderstood values of "code reuse".
toqy ยท 29 points ยท Posted at 14:50:03 on October 12, 2018 ยท (Permalink)
And the worst part is nobody will have a fucking clue what
niceTry(urMum);
is even supposed to do, they are going to have to waste time by going to the source. Asinine.
import niceTry from 'niceTry';
niceTry(urMum);
vs
try { urMum(); } catch (e) {}
it's even less fucking characters.
and what if you decide you don't want to be a doofus and actually do something in the catch block one day? dude should have had too little time to discuss the PR that added this bullshit.
๐๏ธ pbfweddit ยท 11 points ยท Posted at 15:17:21 on October 12, 2018 ยท (Permalink)
He also has several other occurrences of try catch pass in the codebase already. No clue why this dependency was added
The truth is that way too many people in npm ecosystem are like both authors, in it for the exposure/glory whatever. Fucking Jon Schlinkerts the lot of them. Then again, given the jokers running the show it's extremely hard to expect any of these issues ever being tackled.
dancorbe ยท 41 points ยท Posted at 07:15:51 on October 12, 2018 ยท (Permalink)
Too bad it wasn't explained that way. "I'm busy, fuck off" is never the right answer.
What โhardโ work? The PR is a couple of lines. Not wanting to inline dependencies is a design decision, and making exceptions for cases as insignificant as this doesnโt seem crazy, since it opens the door for more (potentially problematic) issues in the future. The submitter is free to fork if this is truly a make-or-break for his use-case.
I didn't want to be rude but I was being sincere. The whole subject is controversial and, in the end, it's a personal preference and developers' ideals.
I'm in a tight timeline and I really need all the time I can have. Having the said, I don't have time to write a detailed answer of why I think it's right to "inline" dependencies.
Again, thanks for taking the time to make this post and trying to engage in a conversation where you justified your arguments. But, unfortunately, I don't have the time to justify mine.
When said politely for a solution to a non-issue that represents a larger design point? I think itโs a fine answer. He didnโt have to respond at all. Or do you not believe that this person is being sincere about saying that spending the time to go down the rabbit hole with this person was not the most impactful thing that he could be doing with his time?
Of all the things to take issue with, I donโt see how this one merits much furor.
dancorbe ยท 11 points ยท Posted at 08:34:04 on October 12, 2018 ยท (Permalink)
When said politely
It's not a polite thing to do, though. You've logged into github, you're already typing up a reply, why can't you take an extra 30 seconds to explain something?
Would it be more polite not to respond at all? The guy already said that it has to do with dependency management. That, coupled with the fact that heโs closing the PR, says pretty much all youโd need to know. Beyond that heโd need to go dig up links supporting his position, or conjure examples of times when inlining caused unintentional trouble, and further explain that while this PR might be fine, it opens the door for others to do more of it in the future (and in other projects), which could be seen as an overall net harm.
This would surely be met by a return argument, which would make sense since at that point it would be a full blown discussion.
Again I really donโt think itโs nuts to sidestep a deep dive on an insignificant pull request like this. In a perfect world everyone would have time to follow every disagreement up with a full discussion. In the real world thereโs only so much time. The maintainer of this repo was at least decent enough to close the PR and provide a basic reason as to why.
No, two of these were addressed by the PR and the new code would likely bring more attention to the third one now that the visibility of it is increased (which I am starting to believe is the real issue here).
McGlockenshire ยท 263 points ยท Posted at 07:26:04 on October 12, 2018 ยท (Permalink)
nice-tryhas two million, five hundred thousand weekly downloads.It's one line of code, which that PR inlines:
const niceTry = (fn) => { try { return fn() } catch (e) {} };It's had 41 commits, the majority of which are fiddling with the testing or the building, or, hilariously, the goddamn fucking requirements for the build and test environment.
The only single commit after the initial commit that touched the actual code that runs is removing the newline before the catch. That happens like two years in.
And all of this for catching and discarding an exception, which is a cardinal sin.
This seems really, really, really fucking stupid, but what do I know, I'm a filthy 1xer.
[deleted] ยท 43 points ยท Posted at 10:59:24 on October 12, 2018 ยท (Permalink)*
[deleted]
Hueho ยท 32 points ยท Posted at 13:19:46 on October 12, 2018 ยท (Permalink)
Oh hey remember when adding too many comments to your function would make it not able to be inlined?
Good times.
[deleted] ยท 25 points ยท Posted at 14:45:37 on October 12, 2018 ยท (Permalink)*
[deleted]
ninjaaron ยท 9 points ยท Posted at 15:34:25 on October 12, 2018 ยท (Permalink)
wow
Noughmad ยท 1 points ยท Posted at 08:19:52 on October 13, 2018 ยท (Permalink)
Now you only have to make it red.
-fno-stack-protector ยท 19 points ยท Posted at 02:05:17 on October 13, 2018 ยท (Permalink)
close to 1 commit per character..
tuba_man ยท 10 points ยท Posted at 17:22:43 on October 12, 2018 ยท (Permalink)
unjerk - I don't deal with layer 7 of the OSI bean dip all that often so I gotta ask - I ignore errors in the logs all the time ("oh yeah, it just does that") but is there ever a valid reason to just discard errors in the code itself? I mean I guess "the thing I depend on throws an exception when I give it what should be a valid input" sort of stuff sometimes? I guess? no even that's fucky, what if your dependency gets its shit together
goddamnit fuck
McGlockenshire ยท 18 points ยท Posted at 18:45:27 on October 12, 2018 ยท (Permalink)
case $uj:
So it looks like the canonical suggested use for this is something like
const wtf = niceTry(JSON.decode(problematic_string));whereproblematic_stringmight end up causing the JSON decoder to throw. You don't care what's wrong with the JSON string, you just care about the result, and gettingnullback is perfectly fine because your code will handle it being null through some other means.In this case, ignoring the exception and then handling the failure of the call isn't really fully evil, but it's certainly a problem. Exceptions should be exceptional circumstances that you build protections against.
old_grumpy_grandpa ยท 14 points ยท Posted at 22:04:57 on October 12, 2018 ยท (Permalink)
Wouldn't you still want to log the offending string, so you can see what kind of input is causing issues?
sportif11 ยท 14 points ยท Posted at 09:58:48 on October 13, 2018 ยท (Permalink)
Not if it has sensitive data
davy_jones_locket ยท 5 points ยท Posted at 05:16:56 on November 27, 2018 ยท (Permalink)
Caveat: You can still log these to an audit record, especially if you're tracking who accessed what sensitive data.
YuriKlastalov ยท 5 points ยท Posted at 01:48:20 on October 13, 2018 ยท (Permalink)
Check wtf for null then do whatever. Exceptions are ยน/โ-er heresy anyway. Hurr durr if we don't call it spaghetti code then it isn't!
rajivshah3 ยท 2 points ยท Posted at 06:49:51 on November 27, 2018 ยท (Permalink)
Couldn't you just put the `JSON.decode` inside a `try-catch` block and then return `null` if you have to catch an error?
iamsexybutt ยท 7 points ยท Posted at 20:37:28 on November 26, 2018 ยท (Permalink)
What does 1xer mean?
leodash ยท 16 points ยท Posted at 23:08:05 on November 26, 2018 ยท (Permalink)
10x Developer definition from Techopedia
1xer means a regular developer, not those so-called code ninja, elite hacker whatever.
McGlockenshire ยท 0 points ยท Posted at 23:04:23 on November 26, 2018 ยท (Permalink)
/uj
If you are serious and don't get it, Google
10xerand you will understandsomethingrelevant ยท 139 points ยท Posted at 07:46:32 on October 12, 2018 ยท (Permalink)
One day the javascript ecosystem will be so grand and all-encompassing every new project will be a series of module imports followed by a single
app.run()call. no serious project will have fewer than 10,000 recursive dependencies. node devs will create a whole new filesystem to deal with the infinitely recursing chaos, after which six hundred js developers will reinvent that system in different but equally uninteresting ways.eventually someone working at node will realise no actual code exists in the entire npm library and shut the whole thing down. web devs will shrug and go back to using jQuery for everything, like they secretly always wanted anyway.
PrimozDelux ยท 70 points ยท Posted at 11:09:55 on October 12, 2018 ยท (Permalink)
I wonder if it is possible to create a dependency oriented programming language, where all functionality comes from pulling dependencies sequenced together with a single
app.run()in the endjohn-mememan ยท 35 points ยท Posted at 12:43:53 on October 12, 2018 ยท (Permalink)
Please no
PrimozDelux ยท 67 points ยท Posted at 12:59:24 on October 12, 2018 ยท (Permalink)
hmm, sort of a lambda calculus with npm dependencies. Peano numbers modeled as the length of a dependency chain.. rly makes u think
john-mememan ยท 37 points ยท Posted at 13:18:25 on October 12, 2018 ยท (Permalink)
W E B S C A L E A R I T H M E T I C
R_Sholes ยท 22 points ยท Posted at 13:00:24 on October 12, 2018 ยท (Permalink)
There was some wonky start up with new paradigm of visual programming, where to build a hello world you'd pull from a global repository a block for string constant, a block for systemcall/write, a block for os/exit and a block for executable/linux-i386-elf and so on, and also it's all on a blockchain and every block you use would pay block's developer in some shitcoin, and I don't know whether they would charge for basic blocks or not.
Their whitepaper was going on and on about how hard it is to reuse code in traditional languages and how their "agents" are so much better, carefully avoiding mentioning how their "agents" are just functions, libraries, linkers and compilers but on a blockchain.
BrendanW84 ยท 5 points ยท Posted at 18:31:22 on October 12, 2018 ยท (Permalink)
Thing is though that if it was an ICO no one ever seriously intended to implement it.
defunkydrummer ยท 6 points ยท Posted at 15:11:47 on October 12, 2018 ยท (Permalink)
/uj Yesterday I was thinking that a programming language particularly suited to this should be created. Just for doing the NPM stuff but in a morally righteous way.
isthistechsupport ยท 14 points ยท Posted at 16:14:58 on October 12, 2018 ยท (Permalink)
What commoners call Rust is actually NPM/Rust, or, as I've come to call it, NPM + Rust
defunkydrummer ยท 6 points ยท Posted at 18:10:15 on October 12, 2018 ยท (Permalink)
Yay! Now i can isntall morally!!
fp_weenie ยท 4 points ยท Posted at 21:59:36 on October 12, 2018 ยท (Permalink)
Yes. That language is JavaScript.
xtravar ยท 8 points ยท Posted at 13:24:22 on October 12, 2018 ยท (Permalink)
There are plenty of frameworks with that goal, where everything else is a dependency injection or data file. I donโt think itโs a terrible goal in and of itself...
Whatโs terrible is making a dependency for every function. If everything is an abstraction, nothing is.
DerekSavageCoolCuck ยท 3 points ยท Posted at 10:07:30 on November 27, 2018 ยท (Permalink)
I'm already buying myself rope.
heptahedron_ ยท 1 points ยท Posted at 12:53:10 on October 12, 2018 ยท (Permalink)
Prolog?
Perceptes ยท 1 points ยท Posted at 23:31:27 on October 12, 2018 ยท (Permalink)
It's possible and it exists. It's called JavaScript.
BadBoy6767 ยท 1 points ยท Posted at 18:23:09 on February 1, 2019 ยท (Permalink)
Wouldn't that just be a shell language, technically?
AprilSpektra ยท 16 points ยท Posted at 13:42:51 on October 12, 2018 ยท (Permalink)
Either that or our 100-billion-transistor CPUs with a terabyte of RAM will run software that's stuttery and slow while every webshit on the planet is like, "Why the fuck are you worried about RAM?"
ProfessorSexyTime ยท 15 points ยท Posted at 15:06:48 on October 12, 2018 ยท (Permalink)
This but unironically.
That or the guy who created Vue will somehow figure out how to maintain and use Vue without NPM.
filleduchaos ยท 5 points ยท Posted at 18:58:55 on October 12, 2018 ยท (Permalink)
lol can't read docs
bmarkovic ยท 2 points ยท Posted at 10:38:45 on October 13, 2018 ยท (Permalink)
It may be the Devil (NPM)
Or it may be the Lord (CDN provider)
But you gonna have to serve somebody
Camto ยท 4 points ยท Posted at 12:37:15 on October 12, 2018 ยท (Permalink)
Is this what programming in Python feels like?
VodkaHaze ยท 32 points ยท Posted at 14:11:04 on October 12, 2018 ยท (Permalink)
If you want to!
But python actually has a secret weapon called
a competent standard librarywhich you can solve your problems with in the first place too!How insane is it to have decently designed languages?**
** No one talk about the GIL or the politburo will hear us
defunkydrummer ยท 11 points ยท Posted at 23:03:22 on October 12, 2018 ยท (Permalink)
yeah, with one-line-only lambdas and silly protect-by-convention like
__this_stuff; implicit casts, etc.vytah ยท 93 points ยท Posted at 09:22:28 on October 12, 2018 ยท (Permalink)
It's too hard to click a button to accept a PR, better type dozens of paragraphs to explain why he won't click the button.
Glorious time management skills.
Geez, I wonder why.
saulmessedupman ยท 68 points ยท Posted at 10:01:40 on October 12, 2018 ยท (Permalink)
Followed by 10 paragraphs of shit talking
ninjaaron ยท 53 points ยท Posted at 10:17:53 on October 12, 2018 ยท (Permalink)
Isn't catching and ignoring arbitrary errors an anti-pattern?
PrimozDelux ยท 61 points ยท Posted at 11:11:06 on October 12, 2018 ยท (Permalink)
No it's a little something you academics wouldn't know of called "pragmatism"
bmarkovic ยท 27 points ยท Posted at 13:47:29 on October 12, 2018 ยท (Permalink)
Exception handling: Who does that ivory tower bullshit!?
Anyway, on an unrelated note, which one of the t-shirt designs you like better:
stuffs, err := fancylib.DoWithThing(thing) if err != nil { aWittweFuckoWucko(); }or
doAsyncThings(thing, (err, stuffs) => { if (err) { aWittweFuckoWucko(); } });We will have them in 'avocado', 'French fuschsia' and 'buttermilk yellow'.
With syntax highlighting!
recursive ยท 10 points ยท Posted at 16:14:46 on October 12, 2018 ยท (Permalink)
pls no colors for the
err != nilone. Commander would not be pleased.PrimozDelux ยท 7 points ยท Posted at 21:18:53 on October 12, 2018 ยท (Permalink)
If I saw you wearing that tshirt on campus I'd throw a rock at you
badthingfactory ยท 28 points ยท Posted at 11:33:12 on October 12, 2018 ยท (Permalink)
In my experience, if you don't swallow exceptions they'll show up in logs and you're boss makes you fix them. This is why I use go. Go let's me ignore errors without writing any code which is very DRY.
haskell_leghumper ยท 13 points ยท Posted at 10:36:22 on October 12, 2018 ยท (Permalink)
Not when you're 10x and have millions of downloads per week.
JohnTheScout ยท 11 points ยท Posted at 12:10:56 on October 12, 2018 ยท (Permalink)
Yeah but handling errors requires more lines of code, and the less lines of code you have the more 100xer you become
giant_pulsating_mind ยท 43 points ยท Posted at 19:06:12 on October 12, 2018 ยท (Permalink)
How does shit like this even get added to projects? "Looks like I'm gonna need a try statement here. Hmmm, I wonder if someone has implemented this before me, I'd better search npm".
tomwhoiscontrary ยท 43 points ยท Posted at 14:27:04 on October 12, 2018 ยท (Permalink)
The real WTF here is this line:
const isWin = process.platform === 'win32';Why on earth isn't he using a library for this?!??!
leijurv ยท 52 points ยท Posted at 18:13:25 on October 12, 2018 ยท (Permalink)
Make a library for just that line and make a pull request, he'll have to accept it, to do otherwise would be compromising to his anti dependency inlining worldview.
rubyruy ยท 10 points ยท Posted at 23:44:56 on November 26, 2018 ยท (Permalink)
https://www.npmjs.com/package/is-windows 6 million downloads / week
tomwhoiscontrary ยท 5 points ยท Posted at 10:20:14 on November 27, 2018 ยท (Permalink)
Mother of god https://github.com/jonschlinkert/is-windows/blob/master/index.js
badthingfactory ยท 40 points ยท Posted at 11:28:38 on October 12, 2018 ยท (Permalink)
What did he expect? JavaScript developers are completely addicted to these 750,000 delicious, delicious libraries. You don't just quit using exception swallowing libraries cold turkey.
ProfessorSexyTime ยท 33 points ยท Posted at 15:24:26 on October 12, 2018 ยท (Permalink)
It's called being a shameful and sad web dev who can't have their "intellect" challenged.
mattgrande ยท 8 points ยท Posted at 16:01:13 on October 12, 2018 ยท (Permalink)
The rest of the comments are from July. This one is from an hour ago. ๐ค
Tehpolecat ยท 31 points ยท Posted at 15:42:20 on October 12, 2018 ยท (Permalink)
I simply do not have time to explain why your PR is bad. I can't just go around typing 100s and 100s of words explaining why I won't accept every single pull request. That would just take too much of my time, which I do not have. This PR goes against my design principles, explaining which would just take me way too long. You thin I have time to explain things in detail? I don't, I am a very busy developer. I'm sorry but I just won't discuss this, because of the time constraints, but I appreciate you making this pull request. If I had the time to explain why I won't accept the pull request (I don't), I definitely would. My design principles are simply too complex to summarize in a few sentences, it would take literal hours to lay out the foundations you would need to comprehend my design principals. I hope that helps you understand why a busy developer like me would simply not have the time to type out an explanation.
closed
[deleted] ยท 27 points ยท Posted at 19:51:45 on October 12, 2018 ยท (Permalink)
[deleted]
bmarkovic ยท 11 points ยท Posted at 10:44:56 on October 13, 2018 ยท (Permalink)
He is too busy to edit his
package.jsonevery time he adds an one-liner dependency to the project.old_grumpy_grandpa ยท 23 points ยท Posted at 22:02:44 on October 12, 2018 ยท (Permalink)
>locked as "too heated"
Hahahahahahaha, but seriously what is with webshits and confusing all criticism with flaming?
McGlockenshire ยท 4 points ยท Posted at 02:17:08 on October 13, 2018 ยท (Permalink)
I mean, we kinda brigaded over there. Lots of new votes and comments since this originally went up.
old_grumpy_grandpa ยท 12 points ยท Posted at 10:35:41 on October 13, 2018 ยท (Permalink)
Still doesn't qualify as too heated, it's not like he was told to kys or there was a flame war about tabs vs spaces in the comments. Dude just wanted another way to skirt around the technical side of the discussion.
YEPHENAS ยท 17 points ยท Posted at 13:13:23 on October 12, 2018 ยท (Permalink)
A little copying is better than a little dependency.
[deleted] ยท 24 points ยท Posted at 20:01:20 on October 12, 2018 ยท (Permalink)
excited gopher squeaks
flexmuzik ยท 5 points ยท Posted at 06:35:58 on October 14, 2018 ยท (Permalink)
What is helper function :S
alchemist_ubi ยท 4 points ยท Posted at 04:14:35 on November 27, 2018 ยท (Permalink)
JavaScript community be like:
- I don't agree with you because of my personal feelings and you are re being too pragmatic. Unsub, dislike, and lock the thread.
At what point we learn how to take the craftsmanship seriously and respect the career.
I hope we do not need to go with `leftPad` situation 10 times more and then politicians of this world tell us how to do our job because we suck at it.
No discipline, no respect what so ever.
This is disappointing and I hope I die before what makes me happy in life becomes what I hate the most because of computer science is driven by politics.
"Great power comes with great responsibilities"
But we have 0 accountability for our actions so we just forget about the responsibility part, for now.
Either we learn how to be disciplined or we will hate our job in the near future.
PC__LOAD__LETTER ยท -25 points ยท Posted at 07:11:39 on October 12, 2018 ยท (Permalink)
I donโt see how itโs that big a deal. He doesnโt want to encourage low-impact changes to how his package manages dependencies. So what?
syndbg ยท 27 points ยท Posted at 09:01:50 on October 12, 2018 ยท (Permalink)
uj
The funny jerk part is the nature of the PR, the attitude and github background of the maintainer and most importantly the problem itself.
it's 1 try-catch that anyone can write in any version of JS. Completely comical and misunderstood values of "code reuse".
toqy ยท 29 points ยท Posted at 14:50:03 on October 12, 2018 ยท (Permalink)
And the worst part is nobody will have a fucking clue what
is even supposed to do, they are going to have to waste time by going to the source. Asinine.
vs
it's even less fucking characters.
and what if you decide you don't want to be a doofus and actually do something in the catch block one day? dude should have had too little time to discuss the PR that added this bullshit.
๐๏ธ pbfweddit ยท 11 points ยท Posted at 15:17:21 on October 12, 2018 ยท (Permalink)
He also has several other occurrences of try catch pass in the codebase already. No clue why this dependency was added
bmarkovic ยท 3 points ยท Posted at 10:42:51 on October 12, 2018 ยท (Permalink)
Explaining the joke usually ruins it.
/uj
The truth is that way too many people in npm ecosystem are like both authors, in it for the exposure/glory whatever. Fucking Jon Schlinkerts the lot of them. Then again, given the jokers running the show it's extremely hard to expect any of these issues ever being tackled.
dancorbe ยท 41 points ยท Posted at 07:15:51 on October 12, 2018 ยท (Permalink)
Too bad it wasn't explained that way. "I'm busy, fuck off" is never the right answer.
NeverComments ยท 31 points ยท Posted at 07:29:07 on October 12, 2018 ยท (Permalink)
Plus the "I'm too busy, fuck off" isn't in response to a request for additional work. Someone else has already done all the hard work for him.
The "I'm too busy, fuck off" is because he doesn't want to (read: can't) justify his reasoning for rejecting the PR.
PC__LOAD__LETTER ยท -7 points ยท Posted at 08:09:06 on October 12, 2018 ยท (Permalink)
What โhardโ work? The PR is a couple of lines. Not wanting to inline dependencies is a design decision, and making exceptions for cases as insignificant as this doesnโt seem crazy, since it opens the door for more (potentially problematic) issues in the future. The submitter is free to fork if this is truly a make-or-break for his use-case.
NeverComments ยท 60 points ยท Posted at 08:15:00 on October 12, 2018 ยท (Permalink)
Iโm sorry but I donโt really have time do discuss this subject nor I have the energy.
PC__LOAD__LETTER ยท -12 points ยท Posted at 08:21:15 on October 12, 2018 ยท (Permalink)
If I were submitting an insignificant PR to your project that would be a reasonable thing to say.
NeverComments ยท 50 points ยท Posted at 09:05:53 on October 12, 2018 ยท (Permalink)
I didn't want to be rude but I was being sincere. The whole subject is controversial and, in the end, it's a personal preference and developers' ideals.
I'm in a tight timeline and I really need all the time I can have. Having the said, I don't have time to write a detailed answer of why I think it's right to "inline" dependencies.
PC__LOAD__LETTER ยท -6 points ยท Posted at 15:08:10 on October 12, 2018 ยท (Permalink)
Again, the scenario is completely different. The copy/paste falls flat.
NeverComments ยท 23 points ยท Posted at 17:51:11 on October 12, 2018 ยท (Permalink)
Again, thanks for taking the time to make this post and trying to engage in a conversation where you justified your arguments. But, unfortunately, I don't have the time to justify mine.
PC__LOAD__LETTER ยท -3 points ยท Posted at 21:45:59 on October 12, 2018 ยท (Permalink)
I see, youโre going to continue making the same terrible point over and over.
PC__LOAD__LETTER ยท -4 points ยท Posted at 08:06:14 on October 12, 2018 ยท (Permalink)
When said politely for a solution to a non-issue that represents a larger design point? I think itโs a fine answer. He didnโt have to respond at all. Or do you not believe that this person is being sincere about saying that spending the time to go down the rabbit hole with this person was not the most impactful thing that he could be doing with his time?
Of all the things to take issue with, I donโt see how this one merits much furor.
dancorbe ยท 11 points ยท Posted at 08:34:04 on October 12, 2018 ยท (Permalink)
It's not a polite thing to do, though. You've logged into github, you're already typing up a reply, why can't you take an extra 30 seconds to explain something?
PC__LOAD__LETTER ยท -2 points ยท Posted at 15:16:14 on October 12, 2018 ยท (Permalink)
Would it be more polite not to respond at all? The guy already said that it has to do with dependency management. That, coupled with the fact that heโs closing the PR, says pretty much all youโd need to know. Beyond that heโd need to go dig up links supporting his position, or conjure examples of times when inlining caused unintentional trouble, and further explain that while this PR might be fine, it opens the door for others to do more of it in the future (and in other projects), which could be seen as an overall net harm.
This would surely be met by a return argument, which would make sense since at that point it would be a full blown discussion.
Again I really donโt think itโs nuts to sidestep a deep dive on an insignificant pull request like this. In a perfect world everyone would have time to follow every disagreement up with a full discussion. In the real world thereโs only so much time. The maintainer of this repo was at least decent enough to close the PR and provide a basic reason as to why.
old_grumpy_grandpa ยท 6 points ยท Posted at 22:13:02 on October 12, 2018 ยท (Permalink)
Swallowing exceptions is an issue, relying on a library to do it is an issue too, and not version locking said library is one more issue.
PC__LOAD__LETTER ยท 0 points ยท Posted at 02:32:30 on October 13, 2018 ยท (Permalink)
Yet only one of those was fundamentally addressed by this PR. I disagree that itโs a big deal.
bmarkovic ยท 4 points ยท Posted at 10:53:15 on October 13, 2018 ยท (Permalink)
No, two of these were addressed by the PR and the new code would likely bring more attention to the third one now that the visibility of it is increased (which I am starting to believe is the real issue here).