Mojira Archive
MCM-956

Seat rotation not working on custom entities.

Partner Rank: 3

Partner Team Reporting: Noxcrew

Verification builds and Platforms: Minecraft-Release_UAP_x64_3692779 1.14.30.2_rc1

Summary:

Seat positions on custom entities do not accurately reflect "rotate_rider_by" unless the entity is given a runtime_identifier of boat. This is the first time we've encountered this issue on custom entities, all previous times we used this had been on vanilla entities, and the feature works properly there. Likely you could give the runtime identifier of any vanilla mob, but boat works for sure.

Impact:

Prop/Vehicle based maps are negatively impacted. Custom prop/vehicle entities will have incorrect or unrealistic player positions.

Repro Steps:

  1. Create a world with a behavior pack
  2. Create a custom entity
  3. Give it this component:
    1.             "minecraft:rideable": {
                      "priority": 0,
                      "seat_count": 1,
                      "crouching_skip_interact": true,
                      "family_types": [
                          "player"
                      ],
                      "interact_text": "action.interact.ride.horse",
                      "seats": [
                          {
                              "position": [
                                  0.60,
                                  1.15,
                                  1
                              ]
                          }
                      ]
                  },
      
  1. Load the world, spawn the entity, and sit on it
  2. Enter 3rd person mode and notice where your legs point
  3. Change the component to this and reload the world:
    1.             "minecraft:rideable": {
                      "priority": 0,
                      "seat_count": 1,
                      "crouching_skip_interact": true,
                      "family_types": [
                          "player"
                      ],
                      "interact_text": "action.interact.ride.horse",
                      "seats": [
                          {
                              "position": [
                                  0.60,
                                  1.15,
                                  1
                              ],
                              "rotate_rider_by": 180,
                              "lock_rider_rotation": 90
                          }
                      ]
                  },
      
  1. Notice where your legs point (they will not have changed)
  2. Add the runtime_identifier "minecraft:boat" to the custom entity
  3. Notice your rotation has now changed.

Observed Results:

Rotated seats do not work on custom entities unless they have the runtime_identifier of boat.

Expected Results:
Rotated seats should work properly on custom entities.

Screenshots/Videos attached:

**No.

 

Fixed

[Noxcrew] Joe Arsenault

2020-02-21, 01:03 AM

2020-12-16, 08:09 PM

2020-12-16, 08:09 PM

0

0

Future Release

-