[MCM-727] Tags are not being added and/or removed from entities correctly

Partner Rank: 1

Partner Team Reporting: Spark Squared

Verification builds: 1.13.0.1

Summary:

Tags are not being added and/or removed from entities correctly. Getting added when they should not be, and not removed even when running the appropriate command.

Impact:

Maps using tags will become unplayable, Furniture - Modern being one of them

Repro Steps:

Ensure asserts are off
Place down an impulse command block and two chain command blocks in a line
In the impulse type: /tag @a remove a
In the first chain type: /tag @a remove b
In the third chain type: /tag @a add a
Place down a lever/button and run the three commands

Observed Results:

When typing “/tag @a list”, it outputs the expected result that the player has the “a” tag. However, on removing the tag with “/tag @a remove a” and then running “/tag @a list” again, there is the unexpected addition of the “b” tag, even though it was never explicitly added. Furthermore, upon removing the “b” tag with “tag @s remove b”, the “a” tag re-appears.

When running with asserts on, on attempting to remove the “b” tag (after removing the “a” tag), the following assertion failed:

---------------------------

Assert Failure - ctrl+C to copy this message to the clipboard!

---------------------------

Assertion failed: Attempting to drop a tag that doesn't exist in the cache.

Condition is false: false

Function: ServerLevel::dropEntryFromTagCache in f:\darwinwork\10\s\handheld\src\common\server\serverlevel.cpp @ 254

---------------------------

Expected Results:

The “a” tag should only be added, and then removed with a subsequent “/tag @s remove a”

Screenshots/Videos attached: Yes/No

https://streamable.com/v08fj

Regression Builds:

Tested in 1.12.0.14 and it worked as expected