[MCM-583] Fishing hook not properly killed by command breaking right click detection (affecting live content)

Partner Rank:

Partner Team Reporting:

Pathway Studios

Verification builds and Platforms:

1.10.0.7_rc2_Minecraft-Release_UAP_x64_1846015

1.11.0.8_beta_rc1_Minecraft-Release_UAP_x64_1926090

Summary:

When a fishing hook is killed via command "/kill @e[type=fishing_hook" the hook is killed and the rod retracts, however, the game thinks the hook is still cast. This causes the player to have to cast (right-click) the rod twice to recast the fishing hook.

Impact:

This breaks several right click / input detection mechanisms in in-development content, and content currently on the marketplace (Magma Runner and Ninja Defense). When the player casts the hook, a /testfor command block passes causing <some feature> to happen and then the hook is killed to reset the item. In its current state, if the player tries to use it again, it will fail unless they click it a second time.

Repro Steps:

Creating a new superflat world, place down an impulse command block with the command "/kill @e[type=fishing_hook]" inside.
Place a button on the command block.
Grab a fishing rod, and cast it so the hook is out on the ground.
Press the button on the command block, to kill the fishing hook.
Then proceed to reel in and cast the rod again

Observed Results:

When the steps above are executed, the fishing hook will disappear, which makes it look as if you have reeled in your fishing rod, however when you go to cast your rod a second time, nothing happens, and you must right click again for the hook to be cast.

Expected Results:

After the fishing_hook is killed by command the player should be able to cast the hook again without having to right click twice

Screenshot/Video?

Video: https://drive.google.com/file/d/1krcQGvDWjmpqw22FRjw4hZC6dIsNa8D0/view?usp=sharing

Regression Builds:

1.9.0.15_rc5_1658980

Notes:

Since the player has to use an item twice to notice this bug, it's a real easy one to miss when testing content in betas (we did on our earlier passes). I wouldn't be surprised if quite a few partners were experiencing the bug without even knowing it.