[MCM-455] Changing game mode and exiting the game removes the resource pack from the world.

Partner Rank:

Partner Team Reporting:

Jigarbov Productions

Verification builds and Platforms:

1.9.0.0 Minecraft - Release_1372325 Win10

Summary:

Changing game mode and exiting the game removes the resource pack from the world.

Impact:

This destroys the playbility and look of 100% of the maps that use any sort of resource pack. It's super bad.

Repro Steps:

Copy a world that requires a resource pack into the com.mojang saves folder like the one sent to Greg (1.8 version of papercraft adventure)
Verify that saving and closing the world and opening it again doesn't remove the resource pack. The mobs in this case will be paper thin.
Change the default game mode to creative
change the personal game mode to creative
save and close
open the world again

Observed Results:

The resource pack will have unloaded itself. Now even if you close the game and open it again the resource pack will never attach itself to the world again. However if you dig into the files you can see the resource pack files are still there but the resource pack manifest no longer has the association uuid in there.

Expected Results:

The resource pack shouldn't unload itself ever.

Video attached: Yes

Showing the reproduction steps: Video link

Regression Builds:

1.8 all