[1.8] Damage sensors which filter lightning do not work

Partner Rank: 

2

Partner Team Reporting: 

Polymaps

Verification builds:

ver. 1.8.0.4, build 1235442, Win10

Summary:

Any entity which has a damage sensor filtering for lightning will not work properly. If an event was supposed to run, or damage was supposed to be negated, this will not happen. The entity will take damage as if there were no filter.

Impact:

This will impact all content which makes use of damage sensors and it also affects vanilla gameplay. Pigs cannot transform into Zombie Pigmen when struck, Villagers cannot transform into Witches when struck, etc.

Repro Steps:

1. Create a new world
2. Summon a Pig
3. Summon a Lightning Bolt on top of the pig
4. Notice how the Pig takes damage and doesn't transform into a Zombie Pigman.

For an example where Marketplace Content is affected:

1. Create a new world using the "Santa's Sleigh Ride" template
2. Walk into the Sleigh room (to the right of the Christmas Tree)
3. Pull the lever at the other end of the room
4. Notice how lightning strikes the Sleigh, but it dies instead of shrinking.

Observed Results:

Entities with damage sensors that filter lightning will take damage and no lightning-specific events will run. e.g. Pigs don't transform into Pigmen.

Expected Results:

Damage sensors with a lightning filter should react properly when an entity is struck by lightning and run any associated events.

Screenshots/Videos attached: Yes/No

No

Regression Builds:

vers. 1.7.9.0, build 1200135. Win10

Notes:

Other filters for damage sensors seem to work, but that's not to say that lightning is the only entity affected by this.