Mojira Archive
MCM-1711

query.is_moving is failing to detect vertical movement when flying

Partner Rank:
2

Partner Team Reporting:

Jigarbov Productions

Verification builds:

1.20.40.20, 1.20.40.24, 1.20.50.20,1.20.50.21

Summary:

query.is_moving is failing to detect player vertical movement when flying

Impact:

This breaks every piece of content that used this query to detect vertical movement. This is obviously bad. For my own content this breaks Coloring Artist a recently released piece of content.

Repro Steps:

  1. Download Coloring Artist
  2. walk outside of the particles
  3. fly a little bit
  4. look slightly up to spawn the menu
  5. fly up
  6. stop
  7. fly up

Observed Results:

When you start moving up, it is supposed to detect query.is_moving on the vertical movement and remove the previously spawned menu. Because it doesn't, you can see new menus appear and do not disappear when the player flies straight up or down. This is inconsistent with the launch behavior.

https://www.youtube.com/watch?v=A4D6dUNYMqw

 

Expected Results:

query.is_moving should also detect vertical movement

https://youtu.be/-oLWaB3uNUA

Regression Build:

1.20.30.02

Screenshots / Videos Attached:

above in the observed/expected results

Notes

this is the code in the controller for reference:

"controller.animation.player.head_rotation": {
            "states": {
                "default": {
                    "transitions": [
                        {
                            "looking_up": "!query.is_on_ground && query.target_x_rotation < 0 && !query.is_moving"

{\{                        }}}
                    ],
                    "on_entry": [
                        "/function cb/player_control/looking_down"
                    ]
                },
                "looking_up": {
                    "transitions": [
                        {
                            "default": "query.target_x_rotation >= 20 || query.is_moving"{{                        }

}}
                    ],
                    "on_entry": [
                        "/execute as @s at @s if entity @s[m=creative,tag=!debug] run function cb/player_control/looking_up"
                    ]

{\{                }

}}

{\{            }

}}

Unresolved

jigar frobozz

2023-10-20, 06:18 AM

2023-10-20, 11:50 PM

0

0

Future Release

-