Actor load for released bucketed fish is done after the fish is added to the level, rather than before. This is causing the loaded Properties to not be applied to the custom fish.

Partner Rank:

2

Partner Team Reporting:

Aurafall Studios

Verification builds and Platforms:

ver. 1.18.30

Summary:

If I bucket a custom entity that has properties in the NBT, the bucket item that I get has the properties saved to the buckets NBT, but when I release the custom fish, all the NBT passes to the custom fish except for the properties.

This was confirmed to be caused by the Actor load from the item being done after the fish is added to the level.

 

Impact:

We currently have a completed map waiting for properties and permutations to come out of experimental. This map relies on properties and permutations as there is too much variety to be handled solely with components. In it's current state, this makes properties and permutations unusable for the project, and makes our completed map non functional because even thought the koi contain properties, they lose them upon being bucketed and unbucketed, thus losing many components necessary to function.

Repro Steps:

1. Install the included Carp - Prop-Perm add-on to a world
2. spawn a bunch of custom carp fish, try breeding successfully with seaweed - check NBT
3. bucket a custom carp - check NBT
4. replace the custom carp that you bucketed - check NBT
5. See that the unbucketed carp is the only one that is missing properties in it's NBT, nd you are no longer able to feed them seaweed or breed them with seaweed.

Observed Results:

The unbucketed fish do not contain properties, and thus lose their permutation components.

Expected Results:

The mob should be able to be placed from the bucket with the same NBT that the original mob and the bucketed mob item contain.

Screenshots/Videos attached: Yes/No

Regression Builds:

 

Notes:

I have included not only the Carp - Prop-Perm pack, but also a mcstructure file that has a spawn egg spawned carp, a bucketed carp item, and a released from the same bucket carp, to show that the first two have the properties and the third does not.