[MCM-1552] Some gamerules cannot be changed by commands when cheats are off from npcs

Partner Rank:

Partner Team Reporting:

Jigarbov Productions

Verification builds:

1.19.0.34

Summary:

Some gamerules (the ones below the Activate Cheats switch in the world settings menu) cannot be changed by the gamerule command, when ran by a function in an npc.

Impact:

Many of our maps tend to change gamerules on the fly for various reasons. Sometimes we want to disable mob spawning during the tutorial and re-enable it afterwards, in the case of a survival map (at least two of our more recent maps do this). from an npc

Another use case for this is to provide a way to toggle keepinventory in survival maps, without requiring the player to unlock template settings, enable cheats and switch it themselves. This bug makes it so players HAVE to enable cheats themselves for it to work as intended anyway, defeating the point.

Repro Steps:

Open the provided world to greggo
interact with the npc

Expected:

The gamerule mobgriefing and doweathercycle should enable

Observed:

Nothing happens - The gamerule mobgriefing and doweathercycle dont enable

Screenshots/Videos attached:

world sent to greggo

Regression Builds:

1.18.31

it's https://bugs.mojang.com/browse/MCM-1365 coming back to life but in NPC form