Damage sensors can no longer filter damage dealt by knockback_roar

Partner Rank:
2

Partner Team Reporting:
Everbloom Games

Verification builds:
1.18.30.20_rc3

Summary:
Damage sensors can no longer filter damage dealt by knockback_roar

Impact:
This makes it impossible for entities to respond differently to different damage sources that use knockback roar. For instance, an entity cannot differentiate a roar by a ravager from a roar by a custom entity. We use this in an upcoming map to make entities run different commands when hit by different variants of a roaring entity.

Repro Steps:

1. Open the provided world.
2. There's an entity in front of you constantly doing a knockback roar, with a "damage" tag.
3. The player has a damage sensor that nullifies all damage, unless the other entity has the "damage" tag.
4. Walk up to it.

Observed Results:

You don't take damage, whether the roaring entity has the "damage" tag or not.

Expected Results:

You take damage, because the roaring entity has the "damage" tag. If you remove the tag via /tag @e[type=test:roar] add damage, you no longer take damage from it.

Regression Build:

Worked in 1.18.20.21_rc1

Screenshots/Videos attached:

Gfycat (Expected)