Eating animation no longer scales with item use duration
Partner Rank:
2
Verification builds:
1.18.10.22_rc0, 1.18.20.21_rc1
Summary:
Eating animation no longer scales with item use duration
Impact:
We use edible items with in order to detect when the player is holding down the Use Item input via q.is_using_item; and most of the time, we give it a really long duration (such as 24 real hours) so the player can't realistically consume the item during normal gameplay.
This is useful for things like custom bows, or any sort of item-use detection that doesn't require experimental features.
Before 1.18.10.22_rc0, the item eating animation was slowed down the longer the eating duration was. That way, it would take several hours to even start seeing a noticeable difference in the player's pose while using the item. Since 1.18.10.22_rc0 though, the animation was made to have a fixed speed, and if the item takes too long, the animation simply loops.
This makes it so simply using an item triggers a very noticeable eating animation. This affects some of our maps, including WDW Magic Kingdom; particularly two items:
1. The Autograph Book (in third person). Using the item to turn the page right makes you appear to be eating the book from a third person view.
2. The Blaster from Buzz Lightyear's Space Ranger Spin (in both first and third person). Using the item to shoot makes you appear to be eating the blaster which is clearly unsanitary and potentially dangerous.
Repro Steps:
- Enter the attached world, with another person
- Hold the "Usable Item (1s)" item and hold down the Use Item input
- Hold the "Usable Item (24h)" item and hold down the Use Item input.
Observed Results:
The eating animation for both items runs at the exact same speed, despite the the 24h one taking significantly longer to finish.
You may also notice that the 24h item does not trigger eating particles and sounds like the 1s item does, presumably because those things are still tied to the item's use duration.
Expected Results:
The eating animation for the 24h item is so slow it becomes unnoticeable until several hours into using the item.
Screenshots/Videos attached:
Regression Build:
Last worked in 1.18.2.03_rc2
Notes:
The animation responsible for the eating animation (animation.humanoid.use_item_progress) in the vanilla pack has not changed between these versions, which may suggest that the changes were made to the hard-coded variables variable.use_item_startup_progress and/or variable.use_item_interval_progress