lock_rider_rotation and rotate_rider_by properties in rider component resets player head position based on rideable entities world rotation

[1.18.10]

Partner Rank: 

2

Partner Team Reporting:

Everbloom Studios

Verification builds:

1.18.2.03

 

Summary:

We've tested and noticed a strange behavior that wasn't present before within rideable components when trying out this version. Essentially based on the world rotation of a rideable entity, when "lock_rider_rotation" is set within a seat's property as well as a "rotate_rider_by" offset, the players head will be snapped to the opposite limit of rotation it's allowed (possibly basing the angle off of the rideable entity and not on the player riding it with the appropriate rotation offsets)

 

The expected behaviors were that of a simple rotation lock like in previous versions that do not snap into edge thresholds.

 

We saw none of this odd behavior on the following Minecraft versions.

• Minecraft Version: 1.18.0
• Minecraft Version: 1.18.2

 

Walt Disney World Minecraft and other future maps are affected by this bug, as well as many previous maps. This implies that visual control on rideable entities can become off-putting and unnaturally limited at certain points.

 

Impact:

This breaks several of our maps because we often use rideable entities in order to control for better player camera control and other controlled scenarios. In particular this is incredibly apparent in the WDW Minecraft map released recently, as it affects several rides on how they feel when ridden.

It also has an impact on multiple upcoming releases that used this method during development when it still worked.

This can have negative effects on user experience and break immersion.

 

Repro Steps:

To reproduce this bug simply follow the steps in the provided map linked in the Notes section below. But you can reproduce this with any rideable entity with a seat rotation lock and rotation offset.

1. Load the provided map
2. Ride the specialized pig entities (all with the same offsets and locking, but rotated differently)
3. Try looking around
4. If the player's head is suddenly snapped into position on the opposite end of your intended look rotation, then that's the issue in question.
5. You may also use the spawn egg in order to test it in different angles

Observed Results:

 On 3 of the pig entities it causes no issues whatsoever, but on one of them with a particular rotation, my head gets snapped into the opposite side after a certain unclear threshold. It also seems to only happen when the player is in first person view.

Expected Results:

 The player should not have their heads snap on the opposite end, and shouldn't interrupt them halfway. It's expected to be in relation to the entity's rotation and applied to the player based on that, regardless of their view point.

 

Video:

Bug world entity rotation issue

 

Notes:

Bug World MC V1.18.10 (7809942)