Mojira Archive
MCM-1459

Language files - Invalid comments

Partner Rank: 4
Partner Team Reporting: Blockception
Verification builds: 1.17.40

Summary:

All languages files contain improper use of comments, by official convention and documentation, a comment after a translation value starts with a tab followed by two ##.
A lot of comments are single # or triple.

Found 28008 affected lines of translations that do not follow this convention.

Note: Documentation on .lang files are all over the place. But by receiving ms feedback and talks it should be `\t##`

Impact:

  • Good examples for the community to use.
  • Correct working vanilla data-driven files.

Repro Steps:

Observed Results:

Expected Results:

Correct, consistent comments

Screenshots/Videos attached: No
Regression Builds: N/A

Notes:

Suggested course of action:

Using vscode search and replace with regular expression:

Find: '[ \t]+#+'
Replace: '\t##'

for `en_US.lang` goto line 1941, or key: `raytracing.RTX.name` and fix the comment.

Files:

  • Resourcepack\texts\bg_BG.lang
  • Resourcepack\texts\ja_JP
  • Resourcepack\texts\zh_TW
  • Resourcepack\texts\bg_BG.lang
  • Resourcepack\texts\cs_CZ.lang
  • Resourcepack\texts\da_DK.lang
  • Resourcepack\texts\de_DE.lang
  • Resourcepack\texts\el_GR.lang
  • Resourcepack\texts\en_GB.lang
  • Resourcepack\texts\en_US.lang
  • Resourcepack\texts\es_ES.lang
  • Resourcepack\texts\es_MX.lang
  • Resourcepack\texts\fi_FI.lang
  • Resourcepack\texts\fr_CA.lang
  • Resourcepack\texts\fr_FR.lang
  • Resourcepack\texts\hu_HU.lang
  • Resourcepack\texts\id_ID.lang
  • Resourcepack\texts\it_IT.lang
  • Resourcepack\texts\ja_JP.lang
  • Resourcepack\texts\ko_KR.lang
  • Resourcepack\texts\nb_NO.lang
  • Resourcepack\texts\nl_NL.lang
  • Resourcepack\texts\pl_PL.lang
  • Resourcepack\texts\pt_BR.lang
  • Resourcepack\texts\pt_PT.lang
  • Resourcepack\texts\ru_RU.lang
  • Resourcepack\texts\sk_SK.lang
  • Resourcepack\texts\sv_SE.lang
  • Resourcepack\texts\tr_TR.lang
  • Resourcepack\texts\uk_UA.lang
  • Resourcepack\texts\zh_CN.lang
  • Resourcepack\texts\zh_TW.lang

Unresolved

Daan Verstraten

2021-11-01, 01:04 PM

2021-11-02, 12:12 AM

0

0

Future Release

-