Custom item names in translation strings are not namespaced

Partner Rank:

2

Partner Team Reporting:

Everbloom Games

Verification builds:

1.16.100.57

Summary:

Custom item names in translation strings are not namespaced

Impact:

This makes custom items in existing maps that have custom items available to the player have cryptic names as opposed to their intended name. e.g. if a map has a custom:quiver item, whose name is meant to be "Quiver", the name displayed will actually be item.quiver.name instead. Before 1.16.100.56, the proper translation string would have been item.custom:quiver.name, but as of 1.16.100.57, the custom: namespace is removed.

Also, this bug may cause name collisions with vanilla items if, for example, a map implements a custom map:apple item that is distinct from the vanilla apple. Before, the translation string would have been item.map:apple.name, allowing the creator to use a different name from the vanilla apple. With this bug, the translation string is changed to item.apple.name, which points to the vanilla Apple item name.

Affects an upcoming map of ours that is already done, and another one in development.

Repro Steps:

1. Open the provided world
2. Head to the blue-floored chunk with 3 buttons and an item frame
3. You should see a quiver in the item frame. This is the custom item (test:quiver).
4. Press the last button on the right (Loot Table). Should give you a custom quiver item.
5. Notice the name of the item (there is no language file in the RP so it's just the translation string).

Expected:

The name of the item should be "item.test:quiver.name"

Observed:

The name of the item isbe "item.quiver.name"

Screenshots/Videos attached: Yes/No

No

Regression Builds:

This last worked in 1.16.100.56