Projectiles with catch_fire: true don't deal damage

Partner Rank:

4

Partner Team Reporting:

Everbloom Studios

Verification builds:

1.13.0.7, 1.16.0.1

Summary:

Projectiles with catch_fire: true (inside on_hit>impact_damage) don't deal damage on impact.

Impact:

This is counter intuitive and seems unintended.

We found this in an old (yet upcoming) piece of content. I happened to have copied the old 1.12 small_fireball projectile component, didn't remove the onHit>impact_damage>catchFire and, since it didn't cause the mobs to catch fire, I had left it as-is. Now it doesn't deal damage on impact.

Fortunately I never intended the projectiles to cause fire in the first place, so that field can be removed without sacrificing any functionality. However it took me over an hour of debugging to figure out the cause.

Repro Steps:

1. Join the provided world. You should have a snowball and an egg in your inventory, and ghasts floating around. The behavior pack gives the snowball catch_fire: true, and the egg catch_fire: false
2. Throw a snowball at a ghast.
3. Throw an egg at a ghast.

Observed Results:

The snowball passes right through the ghast without dealing damage.
The egg deals damage.

Expected Results:

Both projectiles should deal damage, as there is no damage sensor on the ghasts that prevents them from taking damage.

Screenshots/Videos attached: Yes/No

Yes

Regression Builds:

1.13.0.6 was the last version where it worked as intended.

Notes:

Observed: https://gfycat.com/RemorsefulJovialEkaltadeta
Expected: The egg's behavior on both projectiles.