Projectiles with destroy_on_hit are now destroyed when hitting an invulnerable entity

Partner Rank:

2

Partner Team Reporting:

Everbloom Studios

Verification builds:

1.16.0.58, 1.16.0.61

Summary:

Projectiles with destroy_on_hit (inside impact_damage, not to be confused with remove_on_hit) are now destroyed when hitting an invulnerable entity. Previously, they would pass through an entity if the entity was immune to the damage (through a damage_sensor that filtered out the projectile's damage). Now it just destroys the projectile regardless of whether the mob was able to take damage or not.

Impact:

Some of our content relies on this old behavior, so that projectiles from the player or from mobs don't get destroyed when passing through an invulnerable entity like a marker or a friendly entity. Now the projectiles are destroyed before they even get a chance to get to their target.

Repro Steps:

1. Join the provided world. There should be an invulnerable llama, and you should have a bow and some snowballs. The snowball behavior was changed so it has impact_damage.destroy_on_hit rather than remove_on_hit
2. Shoot the llama.

Observed Results:

The projectiles get destroyed when they hit the llama, even though the llama doesn't take damage from them.

Expected Results:

The projectiles should pass through the llama.

Screenshots/Videos attached: Yes/No

Yes

Regression Builds:

1.16.0.55

Notes:

Expected: https://gfycat.com/LimpingUnhappyAgama 
Observed: https://gfycat.com/ImmediateElectricGalapagosmockingbird