Book and quill doesn't save changes when edited in offhand
The bug
When a book is signed in the off-hand, when switched back to the main hand, it reverts back to a Book and Quill.
How to reproduce
- Get a Book and Quill
- Switch Book and Quill to off-hand
- Write in the book and sign it
- Switch the book back to the main hand using the F hotkey
Code analysis
Based on 1.11 decompiled using MCP 9.35 rc1
The problem is that the method net.minecraft.network.NetHandlerPlayServer.processCustomPayload(CPacketCustomPayload) only tests for the mainhand when it receives a MC|BEdit or MC|BSign CPacketCustomPayload packet.
2015-07-30, 09:17 PM
2018-07-25, 10:31 PM
2018-07-25, 10:20 PM
18
8
Minecraft 15w31b - Minecraft 1.13
Minecraft 15w31b, Minecraft 15w31c, Minecraft 15w32c, Minecraft 15w35b, Minecraft 15w40b, Minecraft 16w06a, Minecraft 1.9, Minecraft 1.9.2, Minecraft 1.10.2, Minecraft 1.11, Minecraft 1.11.2, Minecraft 1.12 Pre-Release 5, Minecraft 1.12, Minecraft 1.12.1, Minecraft 1.12.2, Minecraft 18w11a, Minecraft 18w19b, Minecraft 1.13