MC-82629 Still exploitable via items
The fix issued in MC-82629 appears to work for placed banners only. After spawning banners with ~1500 skull layers, I've managed to invoke what's essentially a full game crash. The render ticks take up to 64,000ms. I'm absolutely positive this is causing the issue because when not looking at these entities, there's almost no lag, as well as the debug indicated that 'root.gameRenderer.level.entities.entities' took almost 48,000 ms in several instances. Honestly, I don't think limiting layers of banners via rendering will ever fully fix the issue, as the server will still issue arbitrarily sized nbt to all clients, which if I'm not mistaken will crash clients if larger than 32767 bytes. Really the only way to properly fix this is to limit both the rendering of these layers and only parsing the first 20-30 layers for storage server-side.
To reproduce:
1. Run the attached command (banner.txt) in a command block
2. Hold the banner
3. Look at yourself in 3rd person view
4. Observe root.gameRenderer.level.entities.entities go up in the shift+F3 pie chart
2015-07-29, 05:39 AM
2020-02-16, 03:24 AM
2020-02-16, 03:24 AM
0
4
-