Mojira Archive
MC-258279

Particle groups aren't cleared on resource reload

 

When resource packs are reloaded, particles are also cleared in ParticleEngine as shown below in reload.

 

this.particles.clear();
profilerFiller2.startTick();
profilerFiller2.push("upload");
this.textureAtlas.reload(preparations);
profilerFiller2.popPush("bindSpriteSets");

 

However, this doesn't clear tracked particles, such as for the spore blossom, so no more particles in that specific group are able to be spawned until the world is reloaded.

Clearing trackedParticleCounts when the particles are cleared solves the problem.

this.particles.clear();
+ this.trackedParticleCounts.clear();
profilerFiller2.startTick();
profilerFiller2.push("upload");
this.textureAtlas.reload(preparations);
profilerFiller2.popPush("bindSpriteSets");

The result of this fix is spore blossoms as well as any other particles (future, modded, etc.) still being able to emit particles after a resource reload.

 

Fixed

Brandon Silva

[Mojang] SystemInvecklare

2022-12-04, 01:07 AM

2022-12-06, 09:53 AM

2022-12-06, 09:53 AM

2

2

Plausible

Important

Platform

Particles

1.19.2, 1.19.3 Release Candidate 1

1.19.3 Release Candidate 3