Mojira Archive
MC-235101

Unnecessary method override for dispenser behaviors

Using Yarn mappings, the following method exists in the BoatDispenserBehavior class:

@Override
protected void playSound(BlockPointer pointer) {
	pointer.world().syncWorldEvent(WorldEvents.DISPENSER_DISPENSES, pointer.pos(), 0);
}

The immediate superclass, ItemDispenserBehavior, implements the method in the same way, though through invoking a static method:

protected void playSound(BlockPointer pointer) {
	syncDispensesEvent(pointer);
}

private static void syncDispensesEvent(BlockPointer pointer) {
	pointer.world().syncWorldEvent(WorldEvents.DISPENSER_DISPENSES, pointer.pos(), 0);
}

Since the two implementations have the same effect, the BoatDispenserBehavior#playSound override is unnecessary.

Unresolved

haykam

2021-08-24, 02:19 AM

2024-05-30, 10:44 PM

5

0

Plausible

(Unassigned)

1.17.1 - 1.21 Pre-Release 11.17.1, 1.18 Pre-release 1, 1.18.2, 1.19 Release Candidate 2, 1.19, 1.19.3, 1.19.4 Pre-release 1, 1.19.4 Pre-release 3, 1.20.1, 1.20.2 Pre-release 1, 1.20.2 Pre-Release 4, 1.21 Pre-Release 1

-