Autorecipe spam abuse crashing servers
Autorecipe spam can be used to kill servers by tripping the 60s watchdog. While typical packet spam would be prevented by the server config, autorecipe is so bad that it can kill servers with an incredibly small rate. This is due to how awful the recipe system is. Locally, I can see that each recipe packet takes up a whole 50ms - this is PER packet.
The correct fix is to make the recipe system perform sensibly, however that's too invasive of a diff for me to make. So, I opted to include a separate packet limiter in the server that would allow me to specifically set limits for certain packets. The patch I used is here:
You'll notice that the maximum rate for auto recipes is a whooping 5 packets per second before these packets are dropped. People were actually able to cause problems for servers using nothing but an autoclicker.
As a side note, the vanilla packet limiter isn't really good either. Its main problem is that the moment a limit is tripped, it does not act to kill the client - rather it only checks limits every second or so - not exactly anything that would help if the server was actually being overloaded.
2021-01-14, 10:01 PM
2024-05-02, 11:29 AM
2024-05-02, 11:29 AM
1
4