custom nether dimension_type logicalHeight does not actually change the dimension height

The linked datapack is supposed to change the nether height to be 256. I do this by changing the logicalHeight value from 128 to 256. This does not work.

This datapack also adds overworld sky to the nether, that is part of bug report MC-197337

How it should work:
The nether height should change to be 256 blocks height.