Mojira Archive
MC-168669

RconClient.RconClient(ServerInterface, String, Socket) exception handling is faulty

The bug

The constructor net.minecraft.server.rcon.thread.RconClient.RconClient(ServerInterface, String, Socket) (Mojang name) handles the exception from Socket.setSoTimeout incorrectly:

RconClient(ServerInterface serverInterface, String string, Socket socket) {
    super(serverInterface, "RCON Client");
    this.client = socket;
    try {
        this.client.setSoTimeout(0);
    }
    catch (Exception exception) {
        this.running = false;
    }
    this.rconPassword = string;
    this.info("Rcon connection from: " + socket.getInetAddress());
}

Setting this.running = false; here has no effect since false is the default value and is only set once start() is called.

Unresolved

Marcono1234

2019-12-23, 03:03 PM

2023-10-26, 06:52 PM

4

2

Plausible

Low

Platform

Networking

1.15.1

-