MC-159633

Command feedback messages are unnecessarily created during function execution

The bug

Command feedback is never sent to the command source during function execution, but a translatable component for command feedback is always created eagerly on each command execution. This imposes a constant overhead on commands in general and also makes some commands significantly slower in performance.

Examples

The following commands take linear time instead of constant time.

Size of forced chunks
```
/forceload query
```
Deep size of collection
```
/data get storage _ path.to.collection
```
Deep size of compound
```
/data get storage _ path.to.compound
```
Length of string due to quoting and escaping
```
/data get storage _ path.to.string
```

Status:Fixed

Reporter:intsuc

Created:2019-08-24, 09:55 AM

Updated:2023-05-15, 04:26 PM

Resolved:2023-05-15, 04:26 PM

Votes:28

Watchers:12

Confirmation Status:Community Consensus

Mojang Priority:Normal

Category:Commands, Performance

Labels:function

Affects Versions:

1.14.4 - 1.20 Pre-release 1

1.14.4, 19w34a, 19w35a, 1.15 Pre-release 5, 1.15.2, 20w06a, 20w07a, 20w08a, 20w09a, 20w10a, 20w11a, 20w12a, 20w14a, 20w16a, 20w17a, 20w18a, 20w20b, 1.16 Pre-release 5, 1.16.1, 20w27a, 20w29a, 20w30a, 1.16.2 Pre-release 1, 1.16.2 Release Candidate 2, 1.16.2, 1.16.3, 1.16.4 Pre-release 1, 1.16.4, 20w45a, 20w46a, 20w48a, 20w49a, 20w51a, 21w03a, 1.16.5, 21w05b, 21w08b, 21w10a, 21w11a, 21w13a, 21w15a, 21w16a, 21w19a, 1.17 Pre-release 1, 1.17, 1.17.1, 21w37a, 1.18.1, 22w03a, 22w05a, 1.18.2 Pre-release 1, 1.18.2, 22w11a, 22w12a, 1.19 Release Candidate 2, 1.19, 1.19.1, 1.19.2, 22w42a, 22w43a, 22w44a, 22w45a, 22w46a, 1.19.3 Pre-release 3, 1.19.3 Release Candidate 1, 1.19.3 Release Candidate 2, 1.19.3, 23w03a, 23w04a, 23w05a, 23w06a, 23w07a, 1.19.4 Pre-release 1, 1.19.4 Pre-release 3, 1.19.4, 23w12a, 23w13a, 23w14a, 23w16a, 23w17a, 23w18a, 1.20 Pre-release 1

Fix Versions:1.20 Pre-release 2