Mojira Archive
MC-123703

White colored blocks cannot be fully white

The bug

It is impossible for a block in the game to be fully white, the brightest color is 0xFCFCFC.
Disabling ambient occlusion or shading on the block model doesn't fix this.

How to reproduce

  1. Load MC-123703(unzip).zip texture pack into the game.
  2. Take a screenshot, and get the color of the the glowstone block.
    You'll notice that the color code is 0xFCFCFC rather than 0xFFFFFF.

Code analysis / Fix

This is caused by lines 911-913 and 984-986 of the EntityRenderer (MCP name) class:

f8 = f8 * 0.96F + 0.03F;
f9 = f9 * 0.96F + 0.03F;
f10 = f10 * 0.96F + 0.03F; 

Which sets red, green, and blue to 0.99 (0xFCFCFC) even if they were 1.